fix(@schematics/angular): add trusted-proxy-headers migration#33065
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Apr 29, 2026
Merged
fix(@schematics/angular): add trusted-proxy-headers migration#33065alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new schematic migration, trusted-proxy-headers, designed to automatically add the trustProxyHeaders configuration to AngularAppEngine or AngularNodeAppEngine instantiations within server.ts files. The migration also inserts a security-sensitive TODO comment to guide developers. Review feedback identifies a potential syntax error when the migration encounters new expressions without parentheses and suggests improving the detection of existing properties by accounting for string literal keys in object literals.
alan-agius4
force-pushed
the
migration-trusted
branch
3 times, most recently
from
a55328e to
397f73d
Compare
Adds a new schematic migration to automatically add trustProxyHeaders configuration to server.ts files in workspaces where either AngularNodeAppEngine or AngularAppEngine are used.
alan-agius4
force-pushed
the
migration-trusted
branch
from
397f73d to
579f0e4
Compare
dgp1130
approved these changes
Apr 28, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new schematic migration to automatically add trustProxyHeaders configuration to server.ts files in workspaces where either AngularNodeAppEngine or AngularAppEngine are used.